Add strict ID types for BlockId and BlockStateId #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we use |
| ) -> BlockStateId { | ||
| fluid.default_state_index | ||
| } | ||
| // #[allow(clippy::too_many_arguments)] |
Author
There was a problem hiding this comment.
It was an unused function, I can remove it if you like
There was a problem hiding this comment.
on_place is part of the fluid API I think it should not be removed as we might use it later on or expose it for plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This helps prevent misuse of certain ID types as other ID types. I've already found a couple bugs, and I've left FIXMEs on some fluid code that seems to be using
This should be extended in the future to when registries are implemented, for all registries (yes I know the block state registry isn't a real registry but whatever)
Testing
No functionality changes other than correcting a block ID/block state ID confusion