This repository was archived by the owner on Jan 26, 2023. It is now read-only.
postgresql support - only one test failed#25
Open
SledgehammerPL wants to merge 4 commits intoPushjet:masterfrom
Open
postgresql support - only one test failed#25SledgehammerPL wants to merge 4 commits intoPushjet:masterfrom
SledgehammerPL wants to merge 4 commits intoPushjet:masterfrom
Conversation
Author
|
I fixed gcm - now it works with fcm. It could be done better, but I don't know if you want replace GCM or add FCM support. |
Member
|
Let me have a look at the test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I adapted database.py for postgresql, and only one test failed:
I don't know sqlalchemy at all, so can't make automagic choosing in application.py - so I have to add the line in application.py - but if there's a way to check if db.engine is mysql or pgsql - it should be done.