Skip to content
This repository was archived by the owner on Nov 6, 2025. It is now read-only.

register serializable data objects with decorator#34

Merged
seb5g merged 1 commit into5.0.x_devfrom
feature/serialization_registration
Mar 7, 2025
Merged

register serializable data objects with decorator#34
seb5g merged 1 commit into5.0.x_devfrom
feature/serialization_registration

Conversation

@seb5g
Copy link
Contributor

@seb5g seb5g commented Mar 7, 2025

This PR is somewhat related to PyMoDAQ/PyMoDAQ#543

The issue happened mostly because deserialization of data objects unknown of the factory would fail. There is a registration mechanism present in the new method of the object. This would automatically register these (and all their inheriting objects) IF THEY ARE AT LEAST ONCE INSTANTIATED. On the machine/interpreter where the LECO director runs it can receive objects to deserialize while such objects have never been instanciated and there fore not registered. In this PR, I explicitely register known objects now to overcome this. It will be done also for specific objects on the pymodaq side

@seb5g seb5g merged commit 5b14aff into 5.0.x_dev Mar 7, 2025
8 checks passed
@seb5g seb5g deleted the feature/serialization_registration branch March 7, 2025 08:51
@codecov
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.86%. Comparing base (ef2caef) to head (5348d60).
Report is 2 commits behind head on 5.0.x_dev.

Additional details and impacted files
@@              Coverage Diff              @@
##           5.0.x_dev      #34      +/-   ##
=============================================
+ Coverage      76.82%   76.86%   +0.04%     
=============================================
  Files             17       17              
  Lines           3741     3748       +7     
=============================================
+ Hits            2874     2881       +7     
  Misses           867      867              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant