Allow attribute filter to be passed on queries, use during group lookups (Fixes: #7)#8
Open
charles-dyfis-net wants to merge 7 commits intoPylons:masterfrom
Open
Allow attribute filter to be passed on queries, use during group lookups (Fixes: #7)#8charles-dyfis-net wants to merge 7 commits intoPylons:masterfrom
charles-dyfis-net wants to merge 7 commits intoPylons:masterfrom
Conversation
pyramid_ldap/__init__.py
Outdated
Member
There was a problem hiding this comment.
This is probably better as:
attrlist = kw.get('attrlist')
if attrlist is not None:
attrlist = tuple(sorted(attrlist))
cache_key = ( ....
attrlist
)
If only because there needn't be a requirement that attrlist be an actual list instance (e.g. if it's already a tuple).
Member
There was a problem hiding this comment.
Note that the above is probably superseded by the comment below.
Member
|
See comments above. If you choose to make changes like this, maybe you could also add your name to the file I just added to the master named CONTRIBUTORS.txt within an update to this pull request and also add a change note the the CHANGES.txt file and update the docs in docs/index.rst with whatever changes you have? |
Author
|
Sorry about the delay there -- took a little longer than I intended to get signoff. Should be ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids downloading full member list during group lookup (an unwieldy use of bandwidth and cache space).