Feature/out of office #311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add js file to handle the radio box Add route to profile.py Add modal to profile.html Add run main for pycharm
and add out of office logic add out of office to event.py
Codecov Report
@@ Coverage Diff @@
## develop #311 +/- ##
===========================================
- Coverage 98.77% 94.32% -4.45%
===========================================
Files 64 77 +13
Lines 2849 3417 +568
===========================================
+ Hits 2814 3223 +409
- Misses 35 194 +159
Continue to review full report at Codecov.
|
ivarshav
reviewed
Feb 17, 2021
ivarshav
reviewed
Feb 17, 2021
ivarshav
reviewed
Feb 17, 2021
ivarshav
reviewed
Feb 17, 2021
ivarshav
reviewed
Feb 17, 2021
ivarshav
reviewed
Feb 17, 2021
app/internal/out_of_office.py
Outdated
|
|
||
| def update_out_of_office(out_of_office_data_from_req, | ||
| out_of_office_data_from_db): | ||
| activate_out_of_office = '1' |
There was a problem hiding this comment.
Maybe could you please explain this line? why you set always '1'?
ivarshav
reviewed
Feb 17, 2021
ivarshav
reviewed
Feb 17, 2021
|
Great job! |
PureDreamer
reviewed
Feb 20, 2021
app/internal/event.py
Outdated
| event: Event, | ||
| uninvited_contacts: Set[str]) -> List[str]: | ||
| uninvited_contacts: Set[str], | ||
| out_of_office_users: List[Tuple[str, str]]) -> List[str]: |
| activate_out_of_office = '1' | ||
| user = session.query(User).filter_by(id=1).first() | ||
|
|
||
| # TODO: Check if the user exist |
There was a problem hiding this comment.
you could check it with an existing function.
And add modals to profile html
…endar into feature/out-of-office Resolve conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This feature allow the users to set "Out of office"