- 
                Notifications
    You must be signed in to change notification settings 
- Fork 52
Feature/gamesreleasedtoday #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Feature/gamesreleasedtoday #334
Conversation
…eature/gamesreleasedtoday Merging develop
        
          
                app/templates/partials/calendar/feature_settings/game_release_modal.html
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                app/templates/partials/calendar/feature_settings/games_list.html
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                app/templates/partials/calendar/feature_settings/games_list.html
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                app/templates/partials/calendar/feature_settings/games_list.html
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                app/templates/partials/calendar/feature_settings/games_list.html
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I've added insights :)
        
          
                app/templates/partials/calendar/feature_settings/games_list.html
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                app/templates/partials/calendar/feature_settings/games_list.html
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | current_user_settings.update(games_setting_true) | ||
| session.commit() | ||
| else: | ||
| create_model(session, UserSettings, **games_setting_true_for_model) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So i did now but I can't really figure it out, it keeps creating new rows(I think it goes by primary key which is just an incremental id.
Didn't find a way to only update it without duplication other than update.
for now changed it back to update.
        
          
                app/templates/partials/calendar/feature_settings/game_release_modal.html
          
            Show resolved
            Hide resolved
        
              
          
                app/static/js/game_releases.js
              
                Outdated
          
        
      | return response.text(); | ||
| }) | ||
| .then(function (body) { | ||
| document.querySelector("#content-div").innerHTML = body; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
innerText maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Codecov Report
 @@             Coverage Diff             @@
##           develop     #334      +/-   ##
===========================================
- Coverage    95.27%   94.02%   -1.26%     
===========================================
  Files           80       93      +13     
  Lines         3664     4416     +752     
===========================================
+ Hits          3491     4152     +661     
- Misses         173      264      +91     
 Continue to review full report at Codecov. 
 | 
…eature/gamesreleasedtoday
…d changed requests to httpx
…d changed requests to httpx

Added games released today functionality, currently enabled always, will be added to settings once done