Skip to content

Conversation

@paaragon
Copy link
Contributor

Summary

This PR removes the deprecated creation of the arguments.serverless file

Details and comments

@paaragon paaragon requested a review from a team as a code owner November 19, 2025 10:54
@avilches
Copy link
Contributor

LGTM, but I'm not familiar with the arguments feature... The ArgumentsStorage class is still used from RunJobSerializer.create. Does this need to be removed too @Tansito @ElePT ?

@ElePT
Copy link
Collaborator

ElePT commented Nov 20, 2025

I am not super familiar either, but it looks like the class is used in several components, so in order to remove it there would have to be more changes. Maybe that's the plan from the beginning @Tansito, to do it gradually?

@Tansito
Copy link
Member

Tansito commented Nov 20, 2025

Without looking to the implementation yet this PR was created to remove a piece of code that it was generating a file called arguments.serverless. It was needed to maintain backward compatibility for versions previous to 0.26 of Qiskit Serverless. Now that we have all the partners migrated to 0.26 we can just remove it because arguments were migrated to the Object Storage in that exact version: #1671

The access to the arguments in the object storage is being managed by ArgumentsStorage, class added in the previous PR and continue being used by the feature itself in other parts of the API and Scheduler when we need to interact with the arguments file.

@Tansito Tansito self-requested a review November 21, 2025 23:02
@Tansito Tansito merged commit 06dcf42 into main Nov 21, 2025
13 checks passed
@Tansito Tansito deleted the fix-remove-deprecated-file-for-arguments branch November 21, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants