feat(datepicker): Component refactoring and new tokens #2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
…ing dark mode styles and improving color tokens for better consistency
TheoGrandin74
force-pushed
the
feat/datepicker-refactoring
branch
from
b804145 to
81883c0
Compare
…nced functionality and styling
TheoGrandin74
changed the title
rmnbrd
requested changes
Jan 23, 2026
| @@ -0,0 +1,399 @@ | |||
| import { useEffect, useRef, useState } from 'react' | |||
Contributor
There was a problem hiding this comment.
Could you create a folder libs/shared/ui/src/lib/components/date-picker/date-picker-calendar and move this file into it?
| @@ -0,0 +1,65 @@ | |||
| import { twMerge } from '@qovery/shared/util-js' | |||
Contributor
There was a problem hiding this comment.
Could you create a folder libs/shared/ui/src/lib/components/date-picker/date-picker-period-list and move this file into it?
| onChange, | ||
| minDate, | ||
| maxDate, | ||
| showTimeInput, |
Contributor
There was a problem hiding this comment.
I think it would be clearer to rename this to something like showDateTimeInputs
Comment on lines
42
to
48
| const localTimeZone = (() => { | ||
| try { | ||
| return Intl.DateTimeFormat().resolvedOptions().timeZone | ||
| } catch { | ||
| return '' | ||
| } | ||
| })() |
Contributor
There was a problem hiding this comment.
Suggested change
| const localTimeZone = (() => { | |
| try { | |
| return Intl.DateTimeFormat().resolvedOptions().timeZone | |
| } catch { | |
| return '' | |
| } | |
| })() | |
| const localTimeZone = useMemo(() => { | |
| try { | |
| return Intl.DateTimeFormat().resolvedOptions().timeZone | |
| } catch (error) { | |
| return 'Local' | |
| } | |
| }, []) |
…s across components + file architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor of the date-picker component to add new tokens and behaviors. Changes:
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release