Skip to content

Conversation

@jpottinger
Copy link

Test that the services dropdown navigate to the right page

@Test
public void verifyNavigationDevOpsConsultancy () throws InterruptedException{
page.clickServices();
Thread.sleep(1000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpottinger Is there a way can test these without explicitly calling Thread.sleep

Copy link
Contributor

@romarioraffington romarioraffington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the spacing is a bit off. Maybe I should create a contributing.md / styles doc to list these things.

Can you ensure:

  1. You are using 2 spaces for tabs
  2. have a space between () for { for your functions
  3. Ensure the closing } is inline with public

Copy link

@JavonDavis JavonDavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • See Romario's requests for changes regarding code style
  • Please use WebDriverWait instead on forcing the Thread to sleep
  • Next time the name of the pull request should indicate what feature you want to be merged

@JavonDavis
Copy link

JavonDavis commented Aug 10, 2017

@romarioraffington I think a linter that automatically runs on the repo would be a better approach to enforcing code style than the contributing.md

@jpottinger
Copy link
Author

@JavonDavis WebDriverWait was giving error and issues. Will try to implement again.

@jpottinger
Copy link
Author

jpottinger commented Aug 10, 2017

@romarioraffington @JavonDavis Made requested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants