- 
                Notifications
    
You must be signed in to change notification settings  - Fork 25
 
Selectors, tests and functions #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…vigate to the right page
| @Test | ||
| public void verifyNavigationDevOpsConsultancy () throws InterruptedException{ | ||
| page.clickServices(); | ||
| Thread.sleep(1000); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpottinger  Is there a way can test these without explicitly calling Thread.sleep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the spacing is a bit off. Maybe I should create a contributing.md / styles doc to list these things.
Can you ensure:
- You are using 2 spaces for tabs
 - have a space between 
()for{for your functions - Ensure the closing 
}is inline with public 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- See Romario's requests for changes regarding code style
 - Please use WebDriverWait instead on forcing the Thread to sleep
 - Next time the name of the pull request should indicate what feature you want to be merged
 
| 
           @romarioraffington I think a linter that automatically runs on the repo would be a better approach to enforcing code style than the contributing.md  | 
    
| 
           @JavonDavis WebDriverWait was giving error and issues. Will try to implement again.  | 
    
| 
           @romarioraffington @JavonDavis Made requested changes  | 
    
Test that the services dropdown navigate to the right page