-
Notifications
You must be signed in to change notification settings - Fork 2
QUA-126: Update "Data Diff" userguide as per the suggestion. #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iammuze
wants to merge
9
commits into
main
Choose a base branch
from
qua-126-show-a-better-use-case-for-is-data-diff
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+238
−12
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8f62d7b
QUA-126: Update "Data Diff" userguide as per the suggestion.
iammuze 65baef7
QUA-126: Update " Data Diff " userguide.
iammuze c385160
QUA-126: Update "Data Diff " as per the suggestions.
iammuze b59e34d
QUA-126: Update "Data Diff" as per discussion.
iammuze 129142e
Add tweaks
shindiogawa 18cb8b3
QUA-126: Update "Data Diff " check.
iammuze 038a1bd
QUA-126: Integrate Arcade Video in "Data Diff" Check and Demonstrate …
iammuze a446441
QUA-126: Update "Data Diff" check as per your suggestion.
iammuze 11776c8
QUA-126: Add arcade videos as per your suggestions.
iammuze File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found the following issues:
Line 4: The isReplicaOf check is sunsetting
Column 9: Should be is being sunset or is being deprecated (grammatically correct form)
Line 58: The DataDiff report shows:
Column 5: Should be Data Diff report (consistent spacing with the rest of the document)
Line 164: It works automatically you set it up once
Column 27: Missing punctuation - should be It works automatically - you set it up once (add dash or em dash)
Line 166: It catches problems early before they affect
Column 31: Missing punctuation - should be It catches problems early - before they affect (add dash or em dash)
Line 168: It gives you peace of mind you can trust
Column 32: Missing punctuation - should be It gives you peace of mind - you can trust (add dash or em dash)
The document is comprehensive and well-written with clear examples. The main issues are minor punctuation inconsistencies in the Key Takeaways section and one terminology issue at the beginning.