-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: compile Hugr using abstract graph datatype #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
acl-cqc
wants to merge
35
commits into
main
Choose a base branch
from
refactor/hugr_graph
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 99a7416.
b242b34 to
0651887
Compare
0651887 to
365dddc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. the new Hugr could just be HugrGraph(edit: done)setFirstChildrenwe can remove thefreshNodeWithIOandnewWithIOfrom HugrGraph and do that work in the compile monad.What do you think of
onHugr? My thoughts were(blah ->) HugrGraph -> (a, HugrGraph)becoming(blah ->) State HugrGraph aseems like a winState HugrGraph ()rather thanHugrGraph -> HugrGraphseems a bit clunky in HugrGraph.hsmodify \s -> s {hugr=f (hugr s)}), but is it worth having twoonHugrs?No actual splicing of Hugrs yet but everything we need for that is here.
A nice follow-up would probably be to move
parentinto the Compile monad, but nvm.Done on
mainas that has the most test-cases for Hugr generation (compilation of many classical cases removed in stack-machine branch so would not be as well-tested there).