feat: NRP-2403: Dialog enhancements #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 3.5.0-NRP-2403-dialog-enhancements.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
stavros-tomas
changed the title
|
🎉 This PR is included in version 3.5.0-NRP-2403-dialog-enhancements.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.5.0-NRP-2403-dialog-enhancements.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
aidanCQ
reviewed
Nov 11, 2025
|
🎉 This PR is included in version 3.5.0-NRP-2403-dialog-enhancements.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.5.0-NRP-2403-dialog-enhancements.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
aidanCQ
approved these changes
Nov 11, 2025
stavros-tomas
changed the title
stavros-tomas
added a commit
that referenced
this pull request
Nov 11, 2025
This reverts commit 6b87217.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
This could have been implemented in another way as well, for example, by creating a brand-new custom component. Ideally, however, we want to take advantage of the existing “goodies” that ShadCN/Radix provides, such as focus trapping.
We could also have modified the Sheet component, but in this case, we need to block user interaction. The Dialog component is a blocking element, whereas the Sheet is not.
PR helpers