-
Notifications
You must be signed in to change notification settings - Fork 5
Representations of alternating group #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a great start!
In general it looks like most of the implementations really assume N = 4 and are not at all expected to work for anything else, this is completely fine, but the signatures should then be made more specific as well.
src/irreps/anirrep.jl
Outdated
| end | ||
|
|
||
| # TODO: for some reason the analytic expression doesn't match these results, which is from CategoryData | ||
| function _fusiontensor_3x3_to_3() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function name is a bit to generic, since it really only works for A4Irrep
|
So I got the fusion tensors to give correct results, but it's not based on any analytic results. Any strong opinions on keeping it the way it is now, i.e. filling in the entries manually, or should we look more into getting it working analytically? If we agree on the former, I'll have to remove some commented lines which I thought were correct analytic results but didn't end up satisfying the pentagon equation. |
This PR adds the representations of A_N for 0 < N < 5. In particular, RepA4 has a generic fusion style, which is currently untested in TensorKit.
Credits to @lkdvos for several parts of this PR.