Conversation
added 4 commits
October 6, 2020 11:39
qizhou
reviewed
Oct 8, 2020
added 2 commits
October 8, 2020 10:36
qizhou
reviewed
Oct 12, 2020
Contributor
qizhou
left a comment
qizhou
left a comment
There was a problem hiding this comment.
I think we need to add a general description of how it works such as requirements. Further, I feel the code lacks necessary comments.
Contributor
|
In general, it should be self-contained - a reader without too much context can understand the code after reading the comments. |
Contributor
Author
|
Gas consumption of two contracts, RootChainStakingPool saves about 150000 gas for one loop. |
ninjaahhh
reviewed
Oct 12, 2020
Contributor
ninjaahhh
left a comment
ninjaahhh
left a comment
There was a problem hiding this comment.
Gas consumption of two contracts, RootChainStakingPool saves about 150000 gas for one loop.
what are you comparing with?
Contributor
Author
|
Contributor
Author
compare the same test of two contracts, like |
FreshmanQ
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.