Add nonReentrant and delete some require#97
Open
jishankai wants to merge 8 commits intoQuarkChain:masterfrom
Open
Add nonReentrant and delete some require#97jishankai wants to merge 8 commits intoQuarkChain:masterfrom
jishankai wants to merge 8 commits intoQuarkChain:masterfrom
Conversation
* master: Add modifier (QuarkChain#93) Remove unnecessary line after the safe math add in the above line of code (QuarkChain#92) Update SafeMath (QuarkChain#94)
Contributor
|
I think there is a misunderstanding here: I think we could use ReentrancyGuard here but replacing "public" to "external" is not finalized yet. |
jishankai
changed the title
qzhodl
approved these changes
Jul 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #82