Skip to content

Updated library inclusion for ESp32Servo#8

Open
bnshiva wants to merge 1 commit intoRB-ENantel:masterfrom
bnshiva:support_for_esp32
Open

Updated library inclusion for ESp32Servo#8
bnshiva wants to merge 1 commit intoRB-ENantel:masterfrom
bnshiva:support_for_esp32

Conversation

@bnshiva
Copy link

@bnshiva bnshiva commented Oct 20, 2023

This PR is to add support for ESP32 Arch Type: ESP and ARDUINO_ARCH_ESP32. To perform this, we need to include Library from https://github.com/jkb-git/ESP32Servo. This change assumes the ESP32Servo is already downloaded into the Arduino libraries folder

In file included from <path>/Arduino/libraries/RC_ESC/src/ESC.h:16:0,
                 from <path>/Arduino/mysketch/mysketch.ino:5:
<some random path>/T/AppTranslocation//d/Arduino.app/Contents/Java/libraries/Servo/src/Servo.h:77:2: error: #error "This library only supports boards with an AVR, SAM, SAMD, NRF52 or STM32F4 processor."
 #error "This library only supports boards with an AVR, SAM, SAMD, NRF52 or STM32F4 processor."
  ^
exit status 1
Error compiling for board ESP32 Dev Module.

@bnshiva
Copy link
Author

bnshiva commented Oct 20, 2023

@photodude @RB-ENantel @per1234
Can you folks please review once you get a chance. :-) Open to changing this if you feel it needs to be done in a different way

@RB-ENantel
Copy link
Owner

@bnshiva / Thanks for this contribution.

  • Have you been able to test this with real hardware ?
  • How would it be "defined" in an example ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants