FIX: avoid creating new objects, reference pre-existing static objects

[gyfdb]

Using a const reference will tell the compiler to not create a nw stack slot for this, just use the memory returned by the function.

The rest of this code should be 100% match.

[gyfdb]

Check out RBLXDecomp/g3d#3 for fix regarding Matrix3::identity and ::zero. This should improve Math.h's performance for getAxisRotationMatrix.

[luasoft10]

I've checked the matching of the updated function (Draw::constraint) and it seems to only be improved to 94%. This improvement should be reflected in the comment that was placed above the definition for consistency.

You may be oblivious to the fact that, as noted in your other G3D PR, that this project is meant to provide a byte-accurate decompilation of a game that was compiled with a compiler from 2005. What tools are you using (objdiff or similar) to match functions like the one mentioned?

[gyfdb]

Sorry, I did forget this is a decomp project. My PR was meant to provide improved changes and I have never used objdiff, or worked on a decomp project before. The accuracy and notes should be mended next time. I honestly wanted to see what I could contribute. No harm intended.

Note: The G3D PR was from a separate private project that uses G3D. Sorry if that was apart of this project.
* Separate project is not available but notes Arseny Kapoulkine.

[Yakov5776]

Sorry, I did forget this is a decomp project. My PR was meant to provide improved changes and I have never used objdiff, or worked on a decomp project before.

All good, thanks for your consideration and you're correct about those requirements not being mentioned. For this project we're mainly seeking contributors who can help maintain accuracy using tools like objdiff or better yet aid in documenting things, so if you're still interested you can join the discord and we'd be happy to show you around the process.