Conversation
staverm
force-pushed
the
staverm/add-manifest
branch
2 times, most recently
from
66c7a2d to
57191a1
Compare
amber-manifest.json5
Outdated
| // TODO: Pass config values as environment variables. | ||
| env: { | ||
| MY_API_KEY: "${config.my_api_key}", | ||
| PROXY_URL: "${slots.proxy.url}", // keep even if your agent doesn't use it directly |
There was a problem hiding this comment.
non-blocking: might be nice for the comment to explain why this needed
There was a problem hiding this comment.
Purple agents need a proxy slot for cases where e.g. green agent sends MCP URL to purple over a2a, gateway rewrites it, and then purple reaches that MCP over the gateway. The gateway will bind to this slot if it exists. If we don't use the slot interpolation in the manifest, Amber will complain (warning) that the slot is unused.
The agent dev doesn't typically need the env var, we just need the slot so that amber creates a channel to the gateway. the env var is essentially used to suppress the warning.
There was a problem hiding this comment.
Actually I think I'd like to remove the env var all together
Amber will still compile but will give an "unused slot" warning (not nice to be shipping a template that gives a warning). Is that acceptable?
When we move away from the gateway approach, the manifest will still play nicely because the proxy slot is 'optional'. If however we keep the env var, it effectively makes the slot required, so migrating away from the gateway approach, we would need something to bind to this slot just to be able to compile.
staverm
force-pushed
the
staverm/add-manifest
branch
from
57191a1 to
101c505
Compare
2 participants
No description provided.