Skip to content

Conversation

@maribu
Copy link
Member

@maribu maribu commented Nov 19, 2025

Contribution description

As the title says

Testing procedure

The CI should run super fast if it can determine that changes are whitespace only. This should be the case here.

In addition, the diff should be checked for correctness.

Issues/PRs references

#21515

@maribu maribu added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Nov 19, 2025
@maribu maribu added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 19, 2025
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Nov 19, 2025
@riot-ci
Copy link

riot-ci commented Nov 19, 2025

Murdock results

✔️ PASSED

a0257b1 Update tests/unittests/tests-uri_parser/tests-uri_parser.c

Success Failures Total Runtime
18 0 18 02m:40s

Artifacts

@crasbe crasbe added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Nov 19, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we find out who wrote it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was @kaspar030.

I would assume that this was a conscious choice to not add a copyright with regard German legalese.

I think in 2021/2022 Kaspar was employed at Inria, so Inria would be the copyright owner, if that file would be considered as copyrightable under German law.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears like it was Kaspar and Joakim Nohlgård from looking at the original PR when it was added but yeah I think that checks out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

Copy link
Member

@AnnsAnns AnnsAnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the points raised by crasbe

Co-authored-by: Ann🐸 <git@annsann.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants