Introduce KMHACKISA environment variable for ISA-level code injection. #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used with -fno-gpu-rdc, this allows applications to inject ISA into object files. This flag is used for kernel developers to tweak ISA before an optimization can be devised in the compiler.
scchan
reviewed
Aug 21, 2019
Collaborator
scchan
left a comment
scchan
left a comment
There was a problem hiding this comment.
I think this should work
whchung
changed the title
Collaborator
Author
Collaborator
Author
with this PR you are able to inject additional or replace ISA coming out from the compiler. |
Collaborator
Author
|
@scchan This feature is gradually getting picked up by kernel developers in MIOpen team. Wondering could you give this PR another go? Thanks. |
Collaborator
|
@whchung I'd like to get PR1245 first if possible since it's higher priority. This PR will probably have be updated to adapt to those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used with
-fno-gpu-rdc, this allows applications to inject ISA intoobject files. This flag is used for kernel developers to tweak ISA before an
optimization can be devised in the compiler.
The feature is developed for @asroy and @zjing14 . Need verification from their applications first.