This repository was archived by the owner on Jan 26, 2024. It is now read-only.
Correctly set the index value for __shf_up.#2
Open
jchlanda wants to merge 1 commit intoROCm:developfrom
Open
Conversation
Contributor
|
@jchlanda, (self & ~(width-1)) is the lowest lane in the group of width lanes that includes self. If index, the source lane, is below that value, then the shuffle up operation for lane self is a no-op. I do not believe the proposed patch is correct. Suppose width = 4, and self = 2, and lane_delta = 5. Then (self & ~(width-1)) = 0. The first assignment of index results in -3. The proposed patch incorrectly keeps the index at -3, whereas the current code replaces index with 2 which is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see https://www.khronos.org/registry/OpenCL/extensions/intel/cl_intel_subgroups.html for the details of the shuffles.
This was uncovered when writing libclc's Intel subgroup shuffles, which use the same built-in
bpermute(https://github.com/intel/llvm/pull/4664/files) and was failing tests from llvm-test-suite (among others: https://github.com/intel/llvm-test-suite/blob/intel/SYCL/SubGroup/shuffle.hpp#L88).