Python tests #2128
Draft
Python tests #2128
+416
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a comprehensive test suite for Python performance utilities in the MLIR codebase. The changes add unit tests for tuning and performance runner modules, along with necessary test infrastructure.
- Adds test coverage for
tuningRunner.pymodule including verification mode flags and configuration selection logic - Adds test coverage for
perfRunner.pymodule including layout conversions, configuration generation for conv/gemm/attention operations, and command-line parsing - Provides test infrastructure via
conftest.pyto enable testing without GPU hardware dependencies
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mlir/utils/performance/tests/test_tuningRunner.py | Tests for tuning runner verification modes and winning configuration selection |
| mlir/utils/performance/tests/test_perfRunner.py | Tests for performance runner configuration generation, command-line parsing, and layout conversions |
| mlir/utils/performance/tests/conftest.py | Test configuration providing module path setup and HIP runtime stub for GPU-less testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist