Consult hipTensor to determine if an arch is supported when building their examples#333
Open
evedovelli wants to merge 2 commits intoROCm:amd-stagingfrom
Conversation
Collaborator
|
Thanks so much for this change! Can you also change all the subfolders' CMake files that was modified in #324? |
Author
Sure! I'll change all of the CMake files. |
Author
|
Thanks for approving @zichguan-amd! The rocm-examples is currently failing for this PR because the rocm version installed as dependency doesn't yet include my updates in hipTensor. I'll wait till the hipTensor changes are visible before merging this PR. |
be1f580 to
c52ad2f
Compare
c52ad2f to
717b144
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Avoid inconsistency between list of officially supported architectures by hipTensor and the accepted list of architectures when building the examples.
Technical Details
Use a new cmake function provided by hipTensor instead of verifying the architecture against a locally maintained list of supported architectures.
Depends on ROCm/hipTensor#409
Test Plan
CMAKE_HIP_ARCHITECTURESincluding only hipTensor supported architectures.CMAKE_HIP_ARCHITECTURESincluding hipTensor non-supported architectures.Test Result
Submission Checklist