-
Notifications
You must be signed in to change notification settings - Fork 83
Add lane masks bit-shift example, update to CUDA 12.9.1 and HIP SDK 7.1 #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
j-stephan
wants to merge
10
commits into
ROCm:amd-staging
Choose a base branch
from
j-stephan:lane-masks-bit-shift
base: amd-staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
randyh62
approved these changes
Dec 19, 2025
61ab9ee to
d599eed
Compare
Contributor
Author
|
The CUDA issue observed here is fixed by #394 and its upgrade to CUDA 12.8. |
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
d599eed to
5c926a9
Compare
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Collaborator
|
HIP SDK 7.1.1 is out, I wonder if it's a compatibility issue with HIP SDK 6.4 causing the CI to fail |
Contributor
Author
|
Yes, looks like CUB removed that header file with CUDA 12.8. Time to migrate to a newer HIP SDK :-) |
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds more meaningful examples to illustrate the HIP documentation's lane-masks bit-shift section. This PR requires an update to CUDA 12.9.1.
Technical Details
Adds example code, integration into CMake and Makefile build system,
.gitignore,README.mdand Visual Studio files. Updates the top-level files where necessary.Test Plan
Code tested locally on a RDNA GPU.
Test Result
Works as expected.
Added/Updated documentation?
Included Visual Studio files?
Submission Checklist