Skip to content

Skip rccl on gfx1151 #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zichguan-amd wants to merge 1 commit into
base: amd-staging
Choose a base branch
from
+49 −2
Draft

Skip rccl on gfx1151 #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/build_tools/skip_tests_gfx1151.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
rccl_allgather
rccl_allreduce
rccl_broadcast
rccl_buffer_registration
rccl_device_api
rccl_gradient_allreduce
rccl_reduce
rccl_reducescatter
rccl_send_recv
21 changes: 20 additions & 1 deletion .github/workflows/ci_nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,19 @@ jobs:
- name: Run tests
shell: bash
run: |
ctest --test-dir build --output-on-failure 2>&1 | tee ctest_output.log
SKIP_FILE=".github/build_tools/skip_tests_${{ matrix.gpu_config.gpu_target }}.txt"
if [ -f "${SKIP_FILE}" ]; then
echo "## Skipped tests" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
cat "${SKIP_FILE}" >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY

ctest --test-dir build --output-on-failure --exclude-from-file "${SKIP_FILE}" 2>&1 | tee ctest_output.log
else
ctest --test-dir build --output-on-failure 2>&1 | tee ctest_output.log
fi

- name: Test summary
if: ${{ !cancelled() }}
Expand All @@ -216,6 +228,13 @@ jobs:

# Show failed tests if any
if [ "${FAILED}" -gt 0 ]; then
echo "## Failed tests" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
cat build/Testing/Temporary/LastTestsFailed.log >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY

echo "<details><summary>Failed tests output</summary>" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
Expand Down
21 changes: 20 additions & 1 deletion .github/workflows/ci_therock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,19 @@ jobs:
- name: Run tests
shell: bash
run: |
ctest --test-dir build --output-on-failure 2>&1 | tee ctest_output.log
SKIP_FILE=".github/build_tools/skip_tests_${{ matrix.gpu_config.gpu_target }}.txt"
if [ -f "${SKIP_FILE}" ]; then
echo "## Skipped tests" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
cat "${SKIP_FILE}" >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY

ctest --test-dir build --output-on-failure --exclude-from-file "${SKIP_FILE}" 2>&1 | tee ctest_output.log
else
ctest --test-dir build --output-on-failure 2>&1 | tee ctest_output.log
fi

- name: Test summary
if: ${{ !cancelled() }}
Expand All @@ -236,6 +248,13 @@ jobs:

# Show failed tests if any
if [ "${FAILED}" -gt 0 ]; then
echo "## Failed tests" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
cat build/Testing/Temporary/LastTestsFailed.log >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY

echo "<details><summary>Failed tests output</summary>" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
Expand Down
Loading