Open
Conversation
JonathanLichtnerAMD
changed the title
JonathanLichtnerAMD
approved these changes
Jan 14, 2026
Contributor
JonathanLichtnerAMD
left a comment
JonathanLichtnerAMD
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Co-authored-by: Matt Williams <matt.williams@amd.com>
Co-authored-by: Matt Williams <matt.williams@amd.com>
JonathanLichtnerAMD
approved these changes
Jan 15, 2026
mattwill-amd
approved these changes
Jan 15, 2026
…-libraries into users/cderb/log_buffer
…-libraries into users/cderb/log_buffer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A log history would be desirable in the case logging is disabled when an error occurs.
Adding a log buffer to store messages in case they are needed later.
Contents of buffer are dumped to /tmp/miopen_error_ in case of an error log or thrown error.