Prevent atomic collisions on cache line boundary #17752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Still crashes on arm64 |
elad335
force-pushed
the
sleep-hack
branch
2 times, most recently
from
40c9b23 to
64c3dc0
Compare
elad335
changed the title
Contributor
Author
|
Pushed some new fixes |
elad335
force-pushed
the
sleep-hack
branch
7 times, most recently
from
2a54fca to
226700f
Compare
std::unordered_multimap::find may return any matching element.. unlike equal_range. (code relied on matching the first) There was also UB there of reference to an element after it has deleted.
Megamouse
reviewed
Dec 16, 2025
| if (flip_horizontally || flip_vertically) | ||
| { | ||
| Qt::Orientations orientation {}; | ||
| #if QT_VERSION >= QT_VERSION_CHECK(6, 9, 0) |
Contributor
There was a problem hiding this comment.
Nothing in the CI uses old QT.
Why add this back in?
Contributor
Author
There was a problem hiding this comment.
I've been postponing updating it, updating QT is always a bit of a pain. There is also no reason to make it forcibly fail compilation so 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::unordered_multimap::find()may not return the first matching element but any of them, previous code relied on returning the first.