Work on powerpc/beatnik/if_mve network driver (epics codeathon 2021) #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All low-level interfaces were moved to mv643xx_eth.h and the latter is included by if_mve_pub.h.
…speed' argument Remove any calls to mii_ioctl from the low-level driver. Instead, the caller must determine the current speed and communicate to init_hw().
…iver) NOTE: apparently we now must use rtems_bsdnet_event_send(). The combination of rtems_event_send()/rtems_bsdnet_event_receive() apparently no longer works (rtems-5).
Must be careful to skip empty buffers and to correctly identify the last non-empty buffer (since that is the one whose associated descriptor stores the head of the chain for deferred cleanup).
If we have no new buffer then we must recycle/reuse the old one and *not* return it to the user for consumption.
In 'testing' mode the paranoia checks found this bit asserted. The recent linux driver (2013) mentions lists this bit as a 'phy link status change' bit (together with (1<<16)). Thus, we accept this as a 'known' bit now.
Member
|
Till, thanks. I think these should be fine for the I see a reference to the Paul Scherrer Institute in the tag. Is the assignment ok for us to include in RTEMS? Is there any paper work we need to follow up? |
kiwichris
reviewed
Mar 30, 2021
| * a lot less painful. | ||
| */ | ||
| #undef MVETH_DETACH_HACK | ||
| #define MVETH_DEBUG |
Member
There was a problem hiding this comment.
Should this be disabled for the 5 branch?
Member
|
Please re-submit on our GitLab at https://gitlab.rtems.org/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to help porting the if_mve driver (marvell mv643xx chip present on the MVME6100 board) to
rtems-libbsdI broke the existing driver into multiple files:mv643xx_eth.c/mv643xx_eth.h: BSD-agnostic low-level driver. This is always part of the BSP (and can be re-used bya
rtems-libbsddriver).mv643xx_eth_bsdnet.c/if_mve_pub.h: legacy-BSD networking stack support. These files are built into the BSP only if legacylegacy networking is enabled. The legacy stack support sits on top of
mv643xx_eth.Note that no major code changes were made. The driver has always been structured in two layers - at SLAC we used the low-level driver without BSD for special-purpose real-time networking on the second ethernet port.
A companion pull-request in the
rtems-libbsdrepository adds a nexus driver that builds on top ofmv643xx_eth.