Open
Conversation
Altitude multiplied by 1000 gave a wrong result. This is showing an incorrect position at rts2-targetinfo, although the telescope is able to observe it fine as it's getting the position from Telescope::calculateTLE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Altitude multiplied by 1000 gave a wrong result. This is showing an incorrect position at rts2-targetinfo, although the telescope is able to observe it fine as it's getting the position from Telescope::calculateTLE.
Here's an example on how to reproduce it:
With alt -26. This is wrong, the following Python script can confirm:
Alt: 24deg 51' 51.4", Az: 300deg 02' 23.1"
Ra: 02h 14m 17.65s, Dec: +11deg 02' 07.6"
Which matches the RTS2 log:
2024-10-21T08:27:14.765 UTC T0 4100 moving from 11:49:01.282 -067:02:10.11 (altaz +334:10:55.13 +026:23:52.92) to 02:21:58.254 +011:56:43.56 (altaz +122:26:41.28 +025:57:12.27)After this patch, the following output is returned by targetinfo: