change login to use login/logout pages#107
Open
github138 wants to merge 2 commits intoRackTables:masterfrom
Open
change login to use login/logout pages#107github138 wants to merge 2 commits intoRackTables:masterfrom
github138 wants to merge 2 commits intoRackTables:masterfrom
Conversation
github138
force-pushed
the
revert-104-maintenance-0.20.x
branch
from
1eb78a6 to
a5c679f
Compare
Member
Author
|
add display logout reason |
Member
Author
|
rebase on maintenance-0.20.x No issues so far could fixe bugs |
by switching to login/logout page and PHP $_SESSIONS * authenticate (), dispatch (), showLogoutURL(): add login/logout page
github138
force-pushed
the
revert-104-maintenance-0.20.x
branch
from
8bc4a6e to
b8dc7c2
Compare
Member
|
Though commit 73d1e58 fixes the bugs mentioned above HTTP basic authentication does have its drawbacks and it would be good to replace it with something that involves a form, a cookie and a row in a table. If you still would like to work on it please rebase this pull request on the current master branch and let know when you want feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Login behaviour was not as intended.
This is a first try of using a login/logout page and track login status with SESSION variables.
Test with local database und ldap users was successfull.
Experimental!
TODO:
layout