Testsformaster #150
Open
Testsformaster #150
+4,683
−192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed commented binding.pry test tool
This was referenced Jul 1, 2015
Open
|
Looks good to me, and fixes some bugs. Any reason this is still held up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DanielKehoe @tmock12 : regarding testsformaster branch
Note of 20150706 : I added more tests, cleaned up a few files, and removed some.
=> 104 examples, 0 failures, 4 pending
Please take these tests for a spin and if you can help finish the four pending tests, that would be good.
You will need to run:
bundle install
bundle outdated
bundle update
rake db:migrate
export SECRET_KEY_BASE= (run $ rake secret to generate a new key )
rspec
=> 98 examples, 0 failures, 4 pending