[Do not merge] Test a11y plugin changes v2#415
Draft
BenHenning wants to merge 10 commits intoRaspberryPiFoundation:mainfrom
Draft
[Do not merge] Test a11y plugin changes v2#415BenHenning wants to merge 10 commits intoRaspberryPiFoundation:mainfrom
BenHenning wants to merge 10 commits intoRaspberryPiFoundation:mainfrom
Conversation
This hooks up to FocusManager.
Conflicts: package-lock.json package.json src/index.ts src/line_cursor.ts src/navigation.ts src/navigation_controller.ts test/index.ts
Conflicts: src/line_cursor.ts
This contains some initial code changes to incorporate FocusManager. More is happening in Core, and there's still a lot left to figure out.
1 task
This further reduces the amount of responsibility that the plugin has in favor of core + FocusManager changes.
This removes the passive indicator rendering since FocusManager handles it. It also updates part of toolbox navigation to select a first item if there isn't currently a selection (which state is now possible due to tab navigation).
Conflicts: src/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a working branch for bringing in FocusManager support in the keyboard navigation plugin.
Other things left to do:
Pathways untested (or partially tested):
Cool thing to note: this works with Chromevox, though it's rough since group elements over-announce and we don't have good block representations yet. Much of this will be fixed with ARIA work, though. :)
The corresponding core change is here: RaspberryPiFoundation/blockly#8875. Note that the core branch and this branch must be linked together, e.g. using https://developers.google.com/blockly/guides/contribute/samples/debugging#npm_link in order for both to work correctly.