consensus: adjust bip9 periods#1123
Closed
fdoving wants to merge 1 commit intoRavenProject:developfrom
Closed
Conversation
Contributor
Author
|
This was discussed in the dev-meeting on discord yesterday. |
10x the default counting periods. Previous period was 2016 blocks or about 1.4 day. Proposed period is 20160 blocks or about 14 days. - The LOCKED_IN period is extended from 1.4 to 14 days, during which non upgraded nodes will be warned of the upcoming fork. - 10 times as expensive to potentially try to force activation with rented hashpower. - Slower activation. Previous minimum activation time from counting starts, about 3 days, with this proposal about 30 days.
fdoving
force-pushed
the
fdov-adjust-bip9-period
branch
from
ec898a3 to
d6145af
Compare
TronBlack
reviewed
Nov 6, 2021
Collaborator
TronBlack
left a comment
TronBlack
left a comment
There was a problem hiding this comment.
We don't want to change the nPowTargetTimespan or the default nMinerConfirmationWindow.
We should use just the overrides.
The defaults will be used for activation as it reads the chain.
Contributor
Author
|
I was planning on re-opening this issue once i figured out the glitch. (nPowTargetTimespan) - but I pushed to the branch before re-openning, so github won't allow it. New PR: #1124 will comment there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
10x the default counting periods.
Previous period was 2016 blocks or about 1.4 day.
Proposed period is 20160 blocks or about 14 days.