Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 87.06% 87.48% +0.41%
==========================================
Files 48 49 +1
Lines 3882 3938 +56
Branches 431 431
==========================================
+ Hits 3380 3445 +65
+ Misses 313 306 -7
+ Partials 189 187 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c71a63219
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uv run python scripts/generate_example_output_assets.py | ||
| uv run python scripts/smoke_docs_assets.py | ||
| uv run python scripts/smoke_api_payload_snapshot.py |
There was a problem hiding this comment.
Run snapshot verification before regenerating the snapshot
scripts/generate_example_output_assets.py now rewrites files/example-outputs/import-failure-api-payload.json, and this workflow invokes it immediately before scripts/smoke_api_payload_snapshot.py; that makes the smoke check compare against a just-regenerated file instead of the committed baseline, so API payload contract regressions can slip through unnoticed. I checked the same ordering in both ci.yml and python-publish.yml, so the release smoke currently gives a false sense of snapshot stability.
Useful? React with 👍 / 👎.
Summary
This PR prepares the
2.2.8release of ExcelAlchemy.It continues the stable 2.x line with a clearer integration reading path, stronger import-failure payload verification, and more direct install-time smoke coverage for the FastAPI reference app.
What changed
Documentation guidance
docs/integration-roadmap.mdRelease smoke hardening
scripts/smoke_api_payload_snapshot.pyfiles/example-outputs/import-failure-api-payload.jsonpython -m examples.fastapi_reference.appdirectly during install-time release verificationRelease prep
2.2.8changelog entrydocs/releases/2.2.8.mdCompatibility notes
ImportResult,CellErrorMap, andRowIssueMapremain stable public result objects in 2.xstorage=...remains the recommended 2.x backend configuration pathVerification
./.venv/bin/ruff check ../.venv/bin/uv run pyright./.venv/bin/pytest tests/integration/test_examples_smoke.py tests/contracts/test_result_contract.py -q./.venv/bin/python scripts/generate_example_output_assets.py./.venv/bin/python scripts/smoke_api_payload_snapshot.py./.venv/bin/python scripts/smoke_docs_assets.py./.venv/bin/uv run --with fastapi --with httpx --with python-multipart python -m examples.fastapi_reference.appRelease intent
After merge, this branch is intended to be tagged and published as:
v2.2.8