Dev to main Sync #141
Merged
Dev to main Sync #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-template&pipeline add: support staging and production lambda ARNs
…on2-to-3 chore: udpate actions/download-artifact version to 3
fix: lambda taking time
* add: cors and jwt token validation * fix: use key from env * fix: cors middleware * fix: typo * refactor: use cookiname from utils constants and remove unwanted log * add: auth to get lambdas * update cors usage * add: Authentication to the udpate lambda's * refactor: use cors from middlewares * nit: handle error from single place * nit: handle cors and jwt error from single place to avoid duplication * nit: handle error from single place * remove unwanted error check * Refactor: env retrieval from LoadEnvConfig function --------- Co-authored-by: Yash Raj <56453897+yesyash@users.noreply.github.com>
* fix: parameter name * fix: parameter name in template.yaml
MehulKChaudhari
temporarily deployed
to
develop
GitHub Actions
Inactive
MehulKChaudhari
temporarily deployed
to
develop
GitHub Actions
Inactive
prakashchoudhary07
had a problem deploying
to
develop
GitHub Actions
Failure
MehulKChaudhari
requested review from
iamitprakash,
prakashchoudhary07 and
yesyash
yesyash
approved these changes
Jan 22, 2025
iamitprakash
approved these changes
Jan 22, 2025
yesyash
reviewed
Jan 22, 2025
Comment on lines
+66
to
+72
| if req.HTTPMethod == "OPTIONS" { | ||
| return events.APIGatewayProxyResponse{ | ||
| StatusCode: http.StatusOK, | ||
| Headers: headers, | ||
| Body: "", | ||
| }, nil | ||
| } |
Contributor
There was a problem hiding this comment.
- do we need this check as we're returning
statusOkbelow aswell?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 21/Jan/2025
Developer Name: @MehulKChaudhari
Issue Ticket Number
#122
Description
PR's going in
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Screen.Recording.2025-01-21.at.11.35.29.PM.mov