Skip to content

test: implement comprehensive application feedback tests #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamitprakash merged 5 commits into from
Jan 21, 2026
Merged

test: implement comprehensive application feedback tests #2555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a02baf1
feat: add application feedback submission functionality
AnujChhikara Jan 18, 2026
79721d9
feat: enhance application feedback functionality with comprehensive t…
AnujChhikara Jan 19, 2026
9ef5a17
refactor: update application validator tests for improved clarity and…
AnujChhikara Jan 19, 2026
f707633
Merge branch 'develop' into anuj/applications-feedback-tests
AnujChhikara Jan 20, 2026
ed2d28a
test: remove unauthorized user test case for application feedback
AnujChhikara Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
181 changes: 170 additions & 11 deletions test/integration/application.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,33 +376,34 @@ describe("Application", function () {
});
});

it("should return 401 if the user is not super user", function (done) {
it("should return 400 if anything other than status and feedback is passed in the body", function (done) {
chai
.request(app)
.patch(`/applications/${applicationId1}/feedback`)
.set("cookie", `${cookieName}=${jwt}`)
.set("cookie", `${cookieName}=${superUserJwt}`)
.send({
status: "accepted",
batman: true,
})
.end((err, res) => {
if (err) {
return done(err);
}

expect(res).to.have.status(401);
expect(res.body.message).to.be.equal("You are not authorized for this action.");
expect(res).to.have.status(400);
expect(res.body.error).to.be.equal("Bad Request");
expect(res.body.message).to.be.equal('"batman" is not allowed');
return done();
});
});

it("should return 400 if anything other than status and feedback is passed in the body", function (done) {
it("should return 400 if any status other than accepted, rejected or changes_requested is passed", function (done) {
chai
.request(app)
.patch(`/applications/${applicationId1}/feedback`)
.set("cookie", `${cookieName}=${superUserJwt}`)
.send({
status: "accepted",
batman: true,
status: "something",
})
.end((err, res) => {
if (err) {
Expand All @@ -411,18 +412,57 @@ describe("Application", function () {

expect(res).to.have.status(400);
expect(res.body.error).to.be.equal("Bad Request");
expect(res.body.message).to.be.equal('"batman" is not allowed');
expect(res.body.message).to.be.equal("Status must be one of: accepted, rejected, or changes_requested");
return done();
});
});

it("should return 400 if any status other than accepted, rejected or changes_requested is passed", function (done) {
it("should return 200 when submitting feedback with status rejected", function (done) {
chai
.request(app)
.patch(`/applications/${applicationId2}/feedback`)
.set("cookie", `${cookieName}=${superUserJwt}`)
.send({
status: "rejected",
})
.end((err, res) => {
if (err) {
return done(err);
}

expect(res).to.have.status(200);
expect(res.body.message).to.be.equal("Application feedback submitted successfully");
return done();
});
});

it("should return 200 when submitting feedback with status changes_requested and feedback text", function (done) {
chai
.request(app)
.patch(`/applications/${applicationId3}/feedback`)
.set("cookie", `${cookieName}=${superUserJwt}`)
.send({
status: "changes_requested",
feedback: "Please update your skills section with more details",
})
.end((err, res) => {
if (err) {
return done(err);
}

expect(res).to.have.status(200);
expect(res.body.message).to.be.equal("Application feedback submitted successfully");
return done();
});
});

it("should return 400 when status is changes_requested without feedback", function (done) {
chai
.request(app)
.patch(`/applications/${applicationId1}/feedback`)
.set("cookie", `${cookieName}=${superUserJwt}`)
.send({
status: "something",
status: "changes_requested",
})
.end((err, res) => {
if (err) {
Expand All @@ -431,7 +471,126 @@ describe("Application", function () {

expect(res).to.have.status(400);
expect(res.body.error).to.be.equal("Bad Request");
expect(res.body.message).to.be.equal("Status must be one of: accepted, rejected, or changes_requested");
expect(res.body.message).to.include("Feedback is required when status is changes_requested");
return done();
});
});

it("should return 200 when submitting feedback with status accepted and optional feedback text", function (done) {
chai
.request(app)
.patch(`/applications/${applicationId4}/feedback`)
.set("cookie", `${cookieName}=${superUserJwt}`)
.send({
status: "accepted",
feedback: "Great application!",
})
.end((err, res) => {
if (err) {
return done(err);
}

expect(res).to.have.status(200);
expect(res.body.message).to.be.equal("Application feedback submitted successfully");
return done();
});
});

it("should return 200 when submitting feedback with status rejected and optional feedback text", function (done) {
chai
.request(app)
.patch(`/applications/${applicationId5}/feedback`)
.set("cookie", `${cookieName}=${superUserJwt}`)
.send({
status: "rejected",
feedback: "Not a good fit for this role",
})
.end((err, res) => {
if (err) {
return done(err);
}

expect(res).to.have.status(200);
expect(res.body.message).to.be.equal("Application feedback submitted successfully");
return done();
});
});

it("should return 200 when submitting feedback with status accepted and empty feedback string", function (done) {
chai
.request(app)
.patch(`/applications/${applicationId2}/feedback`)
.set("cookie", `${cookieName}=${superUserJwt}`)
.send({
status: "accepted",
feedback: "",
})
.end((err, res) => {
if (err) {
return done(err);
}

expect(res).to.have.status(200);
expect(res.body.message).to.be.equal("Application feedback submitted successfully");
return done();
});
});

it("should return 404 when application does not exist", function (done) {
chai
.request(app)
.patch(`/applications/non-existent-application-id/feedback`)
.set("cookie", `${cookieName}=${superUserJwt}`)
.send({
status: "accepted",
})
.end((err, res) => {
if (err) {
return done(err);
}

expect(res).to.have.status(404);
expect(res.body.error).to.be.equal("Not Found");
expect(res.body.message).to.be.equal("Application not found");
return done();
});
});

it("should return 401 when user is not authenticated", function (done) {
chai
.request(app)
.patch(`/applications/${applicationId1}/feedback`)
.send({
status: "accepted",
})
.end((err, res) => {
if (err) {
return done(err);
}

expect(res).to.have.status(401);
expect(res.body.error).to.be.equal("Unauthorized");
expect(res.body.message).to.be.equal("Unauthenticated User");
return done();
});
});

it("should return 401 if user is not a super user", function (done) {
chai
.request(app)
.patch(`/applications/${applicationId1}/feedback`)
.set("cookie", `${cookieName}=${jwt}`)
.send({
status: "accepted",
})
.end((err, res) => {
if (err) {
return done(err);
}

expect(res).to.have.status(401);
expect(res.body.error).to.be.equal("Unauthorized");
expect(res.body.message).to.be.equal("You are not authorized for this action.");
return done();
});
});
Expand Down
Loading
Loading