-
Notifications
You must be signed in to change notification settings - Fork 167
chore: bump node version to 22.x to support vercel deployment #1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughUpdated Node.js engine version requirements in package.json from 18.x to 24.x, including Volta version specification from 18.14.2 to 24.0.0. This change standardizes the Node.js runtime across the project to version 24. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@package.json`:
- Around line 109-110: Update the Node version pinned in the package.json
"volta" section from "24.0.0" to "24.13.0" and bump the TypeScript Node type
definitions by updating the `@types/node` package entry (in devDependencies or
dependencies) to "24.10.4"; ensure you only change the version strings for the
"volta"."node" field and the "@types/node" dependency (no other changes).
- Around line 98-100: The package.json engines entry currently pins "node":
"24.x" which is incompatible with Storybook 6.4; either revert the engines field
to a supported Node line (e.g., change the "node" value from "24.x" to "22.x")
or upgrade Storybook (update the Storybook package entries in devDependencies
from 6.4 to a current release that documents Node 24 support) and verify
Next.js/Jest compatibility; locate the "engines" object and the Storybook
entries in package.json (devDependencies like `@storybook/`* or storybook
packages) and apply one of these two changes consistently, then run the
build/test matrix to confirm compatibility.
8ab2272 to
fb62953
Compare
fb62953 to
0668408
Compare
Date: 16-01-2026
Developer Name: @MayankBansal12
Issue Ticket Number
Description
(Lint, build, test and dev all are working after updating)
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
working proof
Screencast.from.2026-01-17.04-09-05.mp4
build logs
dev logs
Test Coverage
test run summary
Additional Notes