Skip to content

hotfix: show task status dropdown to backlog task status #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamitprakash merged 2 commits into from
Jan 21, 2026
Merged

hotfix: show task status dropdown to backlog task status #1391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e6c42d
fix: show dropdown for backlog task status
MayankBansal12 Jan 21, 2026
fad4307
test: skip backlog task status dropdown test
MayankBansal12 Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion __tests__/Unit/Components/Tasks/TaskStatusDropdown.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ describe('TaskStatusDropdown', () => {
const msgTag = screen.queryByTestId('msg');
expect(msgTag).toBeNull();
});
it('should show text Backlog when a task with Backlog status is passed down.', () => {
it.skip('should show text Backlog when a task with Backlog status is passed down.', () => {
Copy link
Member Author

@MayankBansal12 MayankBansal12 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipping the test since it's hotfix, will fix tests in another PR

Copy link
Contributor

@AnujChhikara AnujChhikara Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderabbitai can we please raise an PR for writing test for this feature

Copy link

@coderabbitai coderabbitai bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Analysis chain

@AnujChhikara I'll create a GitHub issue to track this follow-up work (I cannot create PRs directly, but an issue will ensure the test work is tracked and can be addressed in a subsequent PR).

🏁 Script executed:

#!/bin/bash
# Create a GitHub issue for writing tests for the backlog feature
gh issue create \
  --title "Write test for Backlog task status dropdown feature" \
  --body "## Context
A test was skipped in PR `#1391` as part of a hotfix to show task status dropdown for backlog task status.

**Skipped test:**
\`\`\`typescript
it.skip('should show text Backlog when a task with Backlog status is passed down.', () => {
    const oldProgress = 100;
    const oldStatus = BACKEND_TASK_STATUS.BACKLOG;

    render(
        <TaskStatusDropdown
            oldProgress={oldProgress}
            oldStatus={oldStatus}
            onChange={onChange}
        />
    );
    const element = screen.getByTestId('task-status-backlog');
    expect(element).toHaveTextContent('Backlog');
});
\`\`\`

**File:** \`__tests__/Unit/Components/Tasks/TaskStatusDropdown.test.tsx\`

## Task
- [ ] Unskip and fix the test for backlog status display
- [ ] Ensure the test properly validates the backlog status behavior in TaskStatusDropdown component
- [ ] Verify all related test cases are passing

## References
- PR: `#1391`
- Comment: https://github.com/RealDevSquad/website-status/pull/1391#discussion_r2714057902
- Requested by: `@AnujChhikara`" \
  --assignee AnujChhikara

Length of output: 58

@AnujChhikara I've created issue #1396 to track the test work for the backlog feature: #1396

The issue includes:

  • Context from this hotfix PR
  • The skipped test code that needs to be fixed
  • A checklist of tasks to complete
  • Assignment to you for tracking

This ensures the follow-up work won't be forgotten and can be addressed in a subsequent PR.

🧬 Code Graph Analysis Results

[File: src/constants/constants.ts, Lines: 55-58]

export const MSG_ON_100_PROGRESS =
    'Proceeding further will make task progress 100%.';

[File: src/constants/constants.ts, Lines: 57-58]

export const MSG_ON_0_PROGRESS =
    'Proceeding further will make task progress 0%.';

[File: src/constants/task-status.ts, Lines: 39-56]

export const BACKEND_TASK_STATUS = {
    UN_ASSIGNED,
    ASSIGNED,
    IN_PROGRESS,
    BACKLOG,
    BLOCKED,
    COMPLETED,
    NEEDS_REVIEW,
    IN_REVIEW,
    APPROVED,
    SMOKE_TESTING,
    SANITY_CHECK,
    REGRESSION_CHECK,
    MERGED,
    RELEASED,
    VERIFIED,
    DONE,
};

[File: src/components/tasks/TaskStatusDropdown.tsx, Lines: 62-176]

export function TaskStatusDropdown({
    isDevMode,
    onChange,
    oldStatus,
    oldProgress,
}: Props) {
    const [{ newStatus, newProgress }, setStatusAndProgress] = useState({
        newStatus: oldStatus,
        newProgress: oldProgress,
    });
    const [message, setMessage] = useState('');

    const getAvailableTaskStatuses = () => {
        return Object.entries(BACKEND_TASK_STATUS).filter(
            ([_, value]) => !EXCLUDED_STATUSES.includes(value)
        );
    };

    const taskStatus = getAvailableTaskStatuses();

    const isCurrentTaskStatusBlock = oldStatus === BACKEND_TASK_STATUS.BLOCKED;
    const isCurrentTaskStatusInProgress =
        oldStatus === BACKEND_TASK_STATUS.IN_PROGRESS;

    const shouldTaskProgressBe100 = (newStatus: string) => {
        const isNewStatusInProgress =
            newStatus === BACKEND_TASK_STATUS.IN_PROGRESS;
        const isNewTaskStatusBlock = newStatus === BACKEND_TASK_STATUS.BLOCKED;
        const isCurrProgress100 = oldProgress === 100;
        return (
            (isCurrentTaskStatusBlock || isCurrentTaskStatusInProgress) &&
            !isNewStatusInProgress &&
            !isNewTaskStatusBlock &&
            !isCurrProgress100
        );
    };

    const shouldTaskProgressBe0 = (newStatus: string) => {
        const isNewStatusInProgress =
            newStatus === BACKEND_TASK_STATUS.IN_PROGRESS;
        const isCurrProgress0 = oldProgress === 0;
        return (
            isNewStatusInProgress &&
            !isCurrentTaskStatusBlock &&
            !isCurrProgress0
        );
    };

    const resetProgressAndStatus = () => {
        setStatusAndProgress({
            newStatus: oldStatus,
            newProgress: oldProgress,
        });
        setMessage('');
    };

    const handleChange = (ev: React.ChangeEvent<HTMLSelectElement>) => {
        const newStatusValue = ev.target.value;
        setStatusAndProgress((prev) => ({
            ...prev,
            newStatus: newStatusValue,
        }));
        if (oldStatus === newStatusValue) {
            return;
        }
        if (isDevMode && newStatusValue !== BACKEND_TASK_STATUS.BACKLOG) {
            const msg = `The progress of current task is ${oldProgress}%. `;
            if (shouldTaskProgressBe100(newStatusValue)) {
                setStatusAndProgress((prev) => ({ ...prev, newProgress: 100 }));
                setMessage(msg + MSG_ON_100_PROGRESS);
                return;
            }
            if (shouldTaskProgressBe0(newStatusValue)) {
                setStatusAndProgress((prev) => ({ ...prev, newProgress: 0 }));
                setMessage(msg + MSG_ON_0_PROGRESS);
                return;
            }
        }
        onChange({ newStatus: newStatusValue });
    };

    const handleProceed = () => {
        const payload: { newStatus: string; newProgress?: number } = {
            newStatus,
        };
        if (newProgress != oldProgress) {
            payload.newProgress = newProgress;
        }
        onChange(payload);
        setMessage('');
    };

    return (
        <>
            <label
                className={
                    isDevMode ? styles.cardPurposeAndStatusFont : undefined
                }
                data-testid={isDevMode ? 'task-status-label' : undefined}
            >
                Status:{' '}
                <TaskStatusSelect
                    newStatus={newStatus}
                    handleChange={handleChange}
                    taskStatus={taskStatus}
                />
            </label>
            <TaskDropDownModel
                message={message}
                resetProgressAndStatus={resetProgressAndStatus}
                handleProceed={handleProceed}
            />
        </>
    );
}

const oldProgress = 100;
const oldStatus = BACKEND_TASK_STATUS.BACKLOG;

Expand Down
16 changes: 5 additions & 11 deletions src/components/tasks/TaskStatusDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,17 +160,11 @@ export function TaskStatusDropdown({
data-testid={isDevMode ? 'task-status-label' : undefined}
>
Status:{' '}
{newStatus === BACKEND_TASK_STATUS.BACKLOG ? (
<span data-testid="task-status-backlog">
{beautifyStatus(newStatus)}
</span>
) : (
<TaskStatusSelect
newStatus={newStatus}
handleChange={handleChange}
taskStatus={taskStatus}
/>
)}
<TaskStatusSelect
newStatus={newStatus}
handleChange={handleChange}
taskStatus={taskStatus}
/>
</label>
<TaskDropDownModel
message={message}
Expand Down