Skip to content

Fix/fix tests #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prakashchoudhary07 wants to merge 3 commits into
base: feature/vitest-setup-3-using-vitest
Choose a base branch
from
Open

Fix/fix tests #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efe0f37
chore: add .vscode in gitignore
prakashchoudhary07 Dec 5, 2022
6d80a37
fix: fix selector for login button
prakashchoudhary07 Dec 5, 2022
12814c1
fix: remove .main-banner element check
prakashchoudhary07 Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
node_modules
tmp
config/local.json
social-media
social-media
.vscode
8 changes: 5 additions & 3 deletions acceptance/new-user/sign-up.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,15 @@ afterAll(async () => {
describe("New user navigates in the page", () => {
test("New user sees a sign up page", async () => {
await page.goto(HOME_PAGE);

await page.waitForResponse((res) => res.url().endsWith("/users/self"));
await page.waitForSelector("button.login-btn-text");

const LOGIN_BUTTON_CSS_SELECTOR = "button.btn-login-text";
await page.waitForSelector(LOGIN_BUTTON_CSS_SELECTOR);

await Promise.all([
page.waitForNavigation(),
page.click("button.login-btn-text"),
page.click(LOGIN_BUTTON_CSS_SELECTOR),
]);

const ghUsernameInput = await page.waitForSelector("input#login_field");
Expand Down
5 changes: 0 additions & 5 deletions visitor-tests/home-page.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ afterAll(async () => {

test("Text checks", async () => {
await page.goto(HOME_PAGE);
await page.waitForSelector(".main-banner");
const bannerText = await page.$eval(".notif", (el) => el.innerText);
expect(bannerText).toMatch(
"New 1 year Anniversary -- New features available for you Check them out!"
);

await page.waitForSelector(".welcome-title");
const titleText = await page.$eval(".welcome-title", (el) => el.innerText);
Expand Down