Skip to content

Conversation

@MayankBansal12
Copy link
Member

@MayankBansal12 MayankBansal12 commented Jan 10, 2026

Date: 11-01-26

Developer Name: @MayankBansal12


Issue Ticket Number

Description

  • replace my site with migrated pages urls

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

demo
Screencast.from.2026-01-11.03-53-15.mp4

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 10, 2026

Deploying welcome-rds with  Cloudflare Pages  Cloudflare Pages

Latest commit: 52eb1fa
Status: ✅  Deploy successful!
Preview URL: https://4ffbe330.welcome-rds.pages.dev
Branch Preview URL: https://replace-my-sit.welcome-rds.pages.dev

View logs

@coderabbitai
Copy link

coderabbitai bot commented Jan 10, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes update URL references across the codebase, migrating navigation from the my.realdevsquad.com subdomain to www.realdevsquad.com, and introduce a new STATUS_BASE_URL constant targeting status.realdevsquad.com for task navigation.

Changes

Cohort / File(s) Summary
Constants and Configuration
js/constants.js
Removed MY_BASE_URL constant; added STATUS_BASE_URL = 'https://status.realdevsquad.com'
Navigation Updates
faq.html, js/navbar.js
Updated four navigation handlers in navbar to use MAIN_SITE and STATUS_BASE_URL instead of MY_BASE_URL-based URLs; updated profile link in faq.html from my subdomain to www subdomain
Authentication Redirect
js/login.js
Changed signup redirect target from https://my.realdevsquad.com/signup to https://www.realdevsquad.com/signup in incomplete user details flow

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Hoppity-hop through links anew,
From 'my' to 'www', the URLs flew,
Status and tasks find their new home,
No broken redirects shall we roam!
Constants refined, the paths align,
A smoother navigation design! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main objective of replacing links to the old my-site with new migrated page URLs across multiple files.
Description check ✅ Passed The description is directly related to the changeset, explaining the intent to replace my site links with migrated pages URLs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)
js/login.js (1)

39-56: Use the MAIN_SITE constant for the base URL instead of hard-coding it (Line 47-49).

The current implementation hard-codes https://www.realdevsquad.com/new-signup, but MAIN_SITE is already defined in constants.js. Import and use it to avoid drift:

import { MAIN_SITE } from './constants.js';

// Then:
return window.location.replace(`${MAIN_SITE}/new-signup`);

This aligns with the existing pattern used in other files and centralizes URL management.

faq.html (1)

56-61: Add js/constants.js before js/navbar.js in faq.html; verify greeting link behavior.

The page currently loads js/navbar.js (line 261) but omits js/constants.js, even though navbar.js references API_BASE_URL (line 21), MAIN_SITE (lines 35, 40, 50, 55), and STATUS_BASE_URL (line 45). This will cause ReferenceErrors at runtime, breaking the dropdown and profile/status/tasks buttons. All other pages (index.html, discord.html, code-of-conduct.html) load both scripts in the correct order.

Additionally, the greeting element at line 57 is an <a href="https://www.realdevsquad.com/"> that triggers a dropdown toggle on click (navbar.js lines 58–62) but lacks preventDefault(), risking unintended navigation.

Proposed fixes
+    <script type="text/javascript" src="./js/constants.js"></script>
     <script type="text/javascript" src="./js/navbar.js"></script>

For the greeting link, either use javascript:void(0) to prevent navigation, or replace the <a> with a styled <button>:

-          <a href="https://www.realdevsquad.com/">
+          <a href="javascript:void(0)">
             <div class="user-greet-msg">Hello, User!</div>
             <img class="user-profile-pic" />
           </a>
🤖 Fix all issues with AI agents
In @js/constants.js:
- Around line 1-3: API_BASE_URL is hardcoded to http://localhost:3000 which
causes mixed-content failures in production; change it to be environment-aware
by computing its value at runtime (similar to the detection in navbar.js) —
e.g., if window.location.hostname indicates production use the secure production
API base (https://<production-api-host>) and otherwise use localhost (or a
configurable env var); update the constant definition for API_BASE_URL so code
that calls `${API_BASE_URL}/auth/signout` uses the correct scheme/host in both
dev and prod.
📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3cff9e0 and 4580225.

📒 Files selected for processing (4)
  • faq.html
  • js/constants.js
  • js/login.js
  • js/navbar.js
🧰 Additional context used
🧬 Code graph analysis (1)
js/navbar.js (1)
js/constants.js (2)
  • MAIN_SITE (2-2)
  • STATUS_BASE_URL (3-3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Cloudflare Pages

@iamitprakash iamitprakash merged commit e23d2db into develop Jan 14, 2026
4 checks passed
@MayankBansal12 MayankBansal12 mentioned this pull request Jan 17, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants