Migrate to requests 2.6.0 version #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a custom line delimiter to iter_lines()
This reverts commit cfd6e25.
This reverts commit 26ed7c2.
After a long discussion in IRC and on several issues, the developers of requests have decided to remove specific functions from requests.utils in version 3.0.0. To give users ample time to prepare for this, we've added DeprecationWarnings long in advance. See also the planning of this in issue psf#2266.
…e_unicode_url Fix failing test test_prepare_unicode_url
Use to_native_string instead of builtin_str
A fix for psf#1979: repeat HTTP digest authentication after redirect.
Pass strict to urllib3.
Cap the redirect_cache size to prevent memory abuse
Ensure pos is set to None when the body is not a file so that HTTPDigestAuth detects the type of the body correctly.
Fix HTTPDigestAuth not to treat non-file as a file
Close sessions created in the functional API
Add overriding Content-Length
While discussion the issue, Donald Stufft (@dstufft) and I realized the simplest solution is to simply add an alias per vendored dependency. The resulting changes are simple and effective. It prevents the issue in 2.5.2 and 2.5.3 where the following would work: from requests.packages import webbrowser This now appropriately raises an ImportError. Closes psf#2465
When working these changes back upstream to pip, we realized that the
previous fix wasn't ideal since unvendoring the packages broke the
imports. For example, if urllib3 were unvendored, then the following
would fail:
from requests.packages import urllib3
…n addition to the currently supported bytes and str input.
…gument to Request.
… input, not float.
Support for bytearray when creating Request with files argument, just like str and bytes.
Only add VendorAliases for vendored dependencies
…ytearray in the files argument. 30-40% performance improvement.
Update support documentation to be more accurate
Document Response.iter_lines() deficiencies
Update urllib3 to 43b5b2b452e4344374de7d08ececcca495079b8d
Importing from urllib3's top-level location causes the namespace to be urllib3.util.retry.Retry instead of requests.packages.urllib3.util.retry.Retry. Without this fix, an using requests with an un-vendored version of urllib3 will break when urllib3's retry handling kicks in. Closes urllib3/urllib3#567
Import urllib3's Retry location from the right place
With the new import machinery in requests/packages/__init__.py people using `python setup.py test` will not be able to run the tests the first time on a new environment. The VendorAlias logic breaks the import machinery and the tests fail. By removing the import of requests in setup.py, we avoid the issue where sys.meta_path continues to have the version of VendorAlias from the import in setup.py. Closes psf#2462
Add return type field to entry-point docstrings
Extract version from requests/__init__.py instead of importing requests
Don't label cookies for the target domain.
Avoid data duplication when creating a Request with str/bytes/bytearray input
Bump version and add release notes for 2.6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.