Add custom authenticator support #39
Conversation
src/catalog.jl
Outdated
| # Step 3: Create the C callback function that wraps the Julia authenticator | ||
| c_callback = @cfunction( | ||
| $( | ||
| function token_callback(user_data::Ptr{Cvoid}, token_ptr::Ptr{Ptr{Cchar}})::Cint |
There was a problem hiding this comment.
Doesn't this have to be marked with Base.@ccallable?
There was a problem hiding this comment.
Went with Option 1 above
There was a problem hiding this comment.
Shouldn't we still mark this as ccallable? I'm not sure I understand Julia here, but in other places we do mark callbacks like that.
There was a problem hiding this comment.
The function itself (token_callback_impl) is ccallable
There was a problem hiding this comment.
It's not, but appears this is not needed for callbacks passed as @cfunction, only when C/Rust initiates communication with Julia code.
| headers=["Authorization" => auth_header, "Polaris-Realm" => realm, "Content-Type" => "application/x-www-form-urlencoded"], | ||
| headers=[ | ||
| "Authorization" => auth_header, | ||
| "Polaris-Realm" => realm, |
There was a problem hiding this comment.
not for this change, but I think this realm might not work for Horizon catalog etc. Are we exposing configuring it through RustyIceberg? And then through raicode...
There was a problem hiding this comment.
Not really exposing anything specific, as these are just general properties via a string map
Co-authored-by: Vukasin Stefanovic <vukasin.stefanovic92@gmail.com>
…yIceberg.jl into feature/gb/custom-auth
This reverts commit 3b14cb7.
| /// Set a custom token authenticator before catalog creation | ||
| pub fn set_token_authenticator( | ||
| &mut self, | ||
| callback: CustomAuthenticatorCallback, |
There was a problem hiding this comment.
Should we construct FFITokenAuthenticator outside of set_token_authenticator and then just set it here?
There was a problem hiding this comment.
FFITokenAuthenticator is rather internal (caching stuff, etc.). So I'd leave that be
2 participants
Relates to RAI-45581