Skip to content

Conversation

@Joselgc1
Copy link
Contributor

Enable menu and account on one line, and icon-only menu items

Description

This update implements a new “Show menu on the top” option that lets an application render its page's navigation directly in the header. It works seamlessly with the existing layouts: the horizontal bar below the header and the vertical side menu. The top and side menu options are mutually exclusive: turning on the top menu automatically disables the side menu and vice-versa.

Additionally, beyond the navigation layout, the update adds display controls everywhere navigation labels show up: pages and workflow steps, and tabs widget, can now show their name, their icon, or both, according to their settings. You can’t hide both name and icon at the same time.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)
  • This change requires a documentation update

Screenshots

Menu Settings:

  • Horizontal bar below the header:
image
  • Menu on the side:
image
  • Menu on the hearder:
image

Display Name and Icons Controls

  • Both:
image
  • Icon Only:
image
  • Name Only:
image

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-backend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Joselgc1 Joselgc1 changed the title AB#121668 AB#121668 - Enable menu and account on one line, and icon-only menu items Oct 14, 2025
const showNameControl = this.tabGroup.get('showName');
const showIconControl = this.tabGroup.get('showIcon');

showNameControl?.valueChanges
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Joselgc1
FYI, you should avoid that with Angular
it's better to access the properties of the form groups like:
this.tabGroup.controls.gridOptions

because you're losing the type when using get('control name')

In the code, there are some places where we still use the get('') but when we can avoid it, let's use typing 👍

@AntoineRelief AntoineRelief merged commit b6c0082 into next Nov 7, 2025
1 check passed
@AntoineRelief AntoineRelief deleted the AB#121668 branch November 7, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants