Skip to content

Conversation

@Maximo-reliefapps
Copy link
Contributor

@Maximo-reliefapps Maximo-reliefapps commented Jul 8, 2024

Description

Updated application model/saving/creation to support a new property: 'variant'. Which is used to toggle the new style on the sidenav for an application.

Useful links

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Modify an application toggling the new style
  • Create + delete an application

Screenshots

Check in the frontend ticket

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-backend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@Maximo-reliefapps Maximo-reliefapps changed the title Add settings option for new sidenav feat/HIT-335 Add optional new style to sidebar Jul 8, 2024
@brunotannus
Copy link
Contributor

Implemented logo feature for backend. More details in the front-end PR

@brunotannus brunotannus requested a review from a team September 10, 2024 02:16
@brunotannus brunotannus self-assigned this Sep 10, 2024
@brunotannus brunotannus added the enhancement New feature or request label Sep 10, 2024
@AntoineRelief AntoineRelief deleted the HIT_335-New-optional-design-for-sidebar branch November 13, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants