Skip to content

Conversation

@RenzoPrats
Copy link
Contributor

@RenzoPrats RenzoPrats commented Nov 14, 2024

Description

Fix: select menus, mainly in tab-main component.

Useful links

ticket

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Opening general tabs of an widget settings and verifying if the select menus are styled properly

Screenshots

Captura de tela de 2024-11-14 17-31-53

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@RenzoPrats RenzoPrats self-assigned this Nov 14, 2024
@RenzoPrats RenzoPrats added the bug Something isn't working label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants