Skip to content

Conversation

@NathanHGit
Copy link
Contributor

@NathanHGit NathanHGit commented Mar 13, 2024

Description

The resource search appeared even if the can search option was unchecked in the resource question. This was due to a wrong value assignment while overriding the onSetValue function and also some conflicts during initialization. I modified the logic of buttons slightly because I noticed some bugs, and I applied the same changes to resource questions.

Useful links

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I created a resource question and a resources question. I verified their behavior with different configurations, both during updating and loading.

Screenshots

peek

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@NathanHGit NathanHGit self-assigned this Mar 14, 2024
@NathanHGit NathanHGit added the bug Something isn't working label Mar 14, 2024
@NathanHGit NathanHGit marked this pull request as ready for review March 14, 2024 09:27
@NathanHGit NathanHGit requested a review from a team March 14, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants