Preserve exclusion/include list and add Progress bar for local mod installation #667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yPackagesFromExtractFolderToTargetDir async to stop UI freezes for larger mods.
TheBestAstroNOT
changed the title
…Wrapper was modified The config used to only be updated once an item was added or deleted.
Contributor
Author
|
Also fixed a bug where adding |
dreamsyntax
suggested changes
Aug 30, 2025
Contributor
dreamsyntax
left a comment
dreamsyntax
left a comment
There was a problem hiding this comment.
LGTM other than translatable string usage
Makes it so they don't come back everytime you open the publish window if you remove them (though I have no idea why anyone would remove these regexes)
dreamsyntax
suggested changes
Sep 30, 2025
Sewer56
reviewed
Sep 30, 2025
| /// <summary> | ||
| /// ViewModel for downloading an individual package. | ||
| /// </summary> | ||
| public class InstallPackageViewModel : INotifyPropertyChanged |
Member
There was a problem hiding this comment.
You should use autogeneration for INotifyPropertyChanged here.
It's been a while since I've worked on R2 but I believe this uses Fody.PropertyChanged.
Member
There was a problem hiding this comment.
This is not the way the rest of the project does this IIRC. Have a quick peek around.
Sewer56
reviewed
Sep 30, 2025
Sewer56
reviewed
Sep 30, 2025
Sewer56
reviewed
Sep 30, 2025
source/Reloaded.Mod.Launcher.Lib/Models/ViewModel/Dialog/PublishModDialogViewModel.cs
Show resolved
Hide resolved
Sorry for the bad commit names, it's a bit late for me rn
Member
|
I will clean this up later- god knows when, but later- still a bit of unneeded AI junk remaining. |
…e in publish menu. Not in real time, too expensive.
Member
|
I resolved myself:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.