Explicit lambda captures to silence warnings #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenwoop
approved these changes
Oct 8, 2025
Collaborator
svenwoop
left a comment
svenwoop
left a comment
There was a problem hiding this comment.
Don't really like that we have to capture all variables individually when also capturing this, but could not find a better solution either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the
[=, this]capture, which copies all local variables and capturesthisby reference, the code now explicitly lists only the necessary variables andthisin the capture list. Since C++20 changes the recommended way of capturing this, we would otherwise have code that throws warnings either in C++20 mode or in C++17 mode. Explicit captures compiles without warnings in both cases.