-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/improvements #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rene-Roscher
wants to merge
35
commits into
main
Choose a base branch
from
feat/improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ownership checks
- Added spatie/laravel-passkeys package for WebAuthn support - Implemented passkey management UI in settings with full CRUD operations - Added passkey authentication option to login page - Enhanced passkey metadata tracking (browser, OS, device type) - Added smart auto-naming based on device detection - Implemented "recently used" badges for passkeys used in last 7 days - Added EN and DE translations for all passkey-related text - Integrated with existing Fortify authentication system - Added security checks to prevent users from locking themselves out - Created usePasskeys composable for frontend WebAuthn operations
- Fixed JSON double-encoding issue in authentication controllers - Published passkeys configuration for proper relying party setup - Fixed translation parameter handling to prevent undefined errors - Ensured proper format for WebAuthn API compatibility
…eyController - Fixed UserAgent service calls to use existing methods (browser(), platform(), etc.) - Corrected recently used check to show passkeys used in last 7 days - Properly detect device type (mobile, tablet, desktop)
- Removed call to non-existent device() method in UserAgent service - Improved generateDeviceName() to create more readable device names - Now generates names like 'Chrome on Mac OS X' or 'Safari on iOS (Mobile)' 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fixed incorrect action class in PasskeyAuthenticationController - Changed from non-existent AuthenticateUsingPasskeyAction to FindPasskeyToAuthenticateAction - Updated authentication logic to use passkey object directly - Added translation function access in script section of Passkeys.vue - Used getCurrentInstance() to access global properties in Vue composition API 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Replaced non-functional ConfirmationStoreDialog with regular Dialog component - Fixed delete confirmation modal now showing proper title and description - Used hard-coded 'Cancel' and 'Delete' button text (consistent with other dialogs) - Removed unused ConfirmationStoreDialog import 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…lation - Created custom Passkey model extending Spatie's with Snowflake ID support - Updated migration to use unsignedBigInteger for Snowflake compatibility - Fixed translation interpolation using string replacement for passkey name - Fixed 403 error by properly comparing Snowflake IDs as strings - Updated config to use custom Passkey model 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Changed from toDateTimeString() to toISOString() for proper timezone handling - Updated formatLastUsed() to show 'Just now' for times less than 60 seconds - Fixed timezone parsing issue that was showing incorrect time differences - Now correctly displays 'Just now' when passkey was just used 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…ent, and improved error handling
…xpiration features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.