Use Shared Memory Access Method on Linux#2
Open
NerduMiner wants to merge 2 commits intoRenolY2:mainfrom
Open
Conversation
Now uses shared memory, with the added benefit of being faster and not requiring sudo permission. However, due to Dolphin immediately unlinking the shared memory after its created on Linux, the library now has to run before a game is started while constantly attempting to access the shared memory object. A bug with Python also causes the object to be deleted after the process ends. The only superficial effect of this update on Linux is that a warning is posted after the library finishes its test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now uses shared memory, with the added benefit of being faster(~5->~1.1 seconds on my laptop) and not requiring sudo permission.
However, due to Dolphin immediately unlinking the shared memory after its created on Linux, the library now has to run before a game is started while constantly attempting to access the shared memory object. A bug with Python also causes the shared memory to be deleted after the process ends.
The only superficial effects of this update on Linux is that a warning is posted after the library finishes its test and processor usage increases while the library waits to hook onto the memory.
There may be a better way to check for when the shared memory object is created but so far just trying to access the object over and over again seems to be the only thing that has worked for me.